Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpdocs and docs #732

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Fix phpdocs and docs #732

merged 1 commit into from
Jul 29, 2023

Conversation

jiaweipan
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues Fix some issues of phpdocs AND docs

@what-the-diff
Copy link

what-the-diff bot commented Jul 29, 2023

PR Summary

  • Improvement in Documentation Syntax
    In the command usage guidelines document, a sentence's construction was enhanced by replacing "and" with a comma for better readability.

  • Refactoring of Method Names in the Query Builder Interface
    For better clarity, the method name "dropColumnComment" was changed to "dropCommentFromColumn." This renaming reflects the actual functionality of this method more accurately.

  • Modification of Comments in the Code
    Along with the method names, their accompanying comments were also modified, aligning them closely with the actions performed by the methods. These changes replace phrases like "adding comment to column" and "adding comment to the table" to "dropping comment to column" and "dropping comment to the table" respectively, ensuring accuracy in the code's explanation.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c01d368) 89.59% compared to head (beffc1e) 89.59%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #732   +/-   ##
=========================================
  Coverage     89.59%   89.59%           
  Complexity     1375     1375           
=========================================
  Files            67       67           
  Lines          3382     3382           
=========================================
  Hits           3030     3030           
  Misses          352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiaweipan jiaweipan changed the title Fix phpdocs AND docs Fix phpdocs and docs Jul 29, 2023
@vjik vjik added the status:code review The pull request needs review. label Jul 29, 2023
@vjik vjik requested a review from a team July 29, 2023 19:44
@vjik vjik merged commit 4434b83 into yiisoft:master Jul 29, 2023
77 of 86 checks passed
@vjik
Copy link
Member

vjik commented Jul 29, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants